Change in openvpn[master]: Add Ubuntu 24.04 runner to Github Actions
A message that is not in the archive (sent off-list or not yet received): gerrit.1721306838000.I44b9003143fdad90bfff7b2c86d0bb503f9157de@...2715...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/676?usp=email
to review the following change.
Change subject: Add Ubuntu 24.04 runner to Github Actions
......................................................................
Add Ubuntu 24.04 runner to Github Actions
---
M .github/workflows/build.yaml
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/76/676/1
.github/workflows/build.yaml +8 -2
@@ -106,7 +106,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04, ubuntu-22.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] sslpkg: [libmbedtls-dev] ssllib: [mbedtls] libname: [mbed TLS]
@@ -122,6 +122,12 @@ ssllib: openssl pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" extraconf: --enable-pkcs11 + - os: ubuntu-24.04 + sslpkg: "libssl-dev" + libname: OpenSSL 3.0.13 + ssllib: openssl + pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" + extraconf: --enable-pkcs11 - os: ubuntu-20.04 sslpkg: "libssl-dev" libname: OpenSSL 1.1.1
@@ -173,7 +179,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] ssllib: [mbedtls, openssl] name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/676?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de
Gerrit-Change-Number: 676
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/676?usp=email )
Change subject: Add Ubuntu 24.04 runner to Github Actions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Test build for this: https://github.com/schwabe/openvpn/actions/runs/9991779456
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/676?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de
Gerrit-Change-Number: 676
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 18 Jul 2024 12:47:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/676?usp=email )
Change subject: Add Ubuntu 24.04 runner to Github Actions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Looks good to me. Should we also update the mingw/libressl/mbedtls builds (where we only build on one Ubuntu version) to Ubuntu 24.04?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/676?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de
Gerrit-Change-Number: 676
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Comment-Date: Thu, 18 Jul 2024 14:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH 1/1 Add Ubuntu 24.04 runner to Github Actions
In reply to a message not in the archiveFrom: Arne Schwabe <[email protected]...>
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/676
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <[email protected]...>
.github/workflows/build.yaml +8 -2
@@ -106,7 +106,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04, ubuntu-22.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] sslpkg: [libmbedtls-dev] ssllib: [mbedtls] libname: [mbed TLS]
@@ -122,6 +122,12 @@ ssllib: openssl pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" extraconf: --enable-pkcs11 + - os: ubuntu-24.04 + sslpkg: "libssl-dev" + libname: OpenSSL 3.0.13 + ssllib: openssl + pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" + extraconf: --enable-pkcs11 - os: ubuntu-20.04 sslpkg: "libssl-dev" libname: OpenSSL 1.1.1
@@ -173,7 +179,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] ssllib: [mbedtls, openssl] name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}"
[Openvpn-devel] [PATCH applied] Re: Add Ubuntu 24.04 runner to Github Actions
Your patch has been applied to the master branch.
I tried to apply it to release/2.6 as well, but the mbedtls builds fail (on 24.04) with error messages like this:
crypto_backend.h:352:6: note: previous declaration of cipher_ctx_init' with type void(cipher_ctx_t *, const uint8_t *, const char *, int)' {aka `void(mbedtls_cipher_context_t *, const unsigned char *, const char *, int)'}
so it seems we need some mbedtls compat backport first, or stop building 2.6 + 24.04 + mbedtls.
Details: https://github.com/cron2/openvpn/actions/runs/10041826490/job/27750800767
(looking more closely, 24.04 + ossl 3 fails as well, with "configure: error: PKCS11 enabled but libpkcs11-helper is missing")
commit 856065b2eb37286c389550593472bf180bc5be9d (master)
Author: Arne Schwabe Date: Fri Jul 19 15:11:41 2024 +0200
Add Ubuntu 24.04 runner to Github Actions
Signed-off-by: Arne Schwabe <[email protected]...>
Acked-by: Frank Lichtenheld <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg28942.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/676?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Add Ubuntu 24.04 runner to Github Actions
......................................................................
Add Ubuntu 24.04 runner to Github Actions
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg28942.html
---
M .github/workflows/build.yaml
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/76/676/2
.github/workflows/build.yaml +8 -2
@@ -106,7 +106,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04, ubuntu-22.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] sslpkg: [libmbedtls-dev] ssllib: [mbedtls] libname: [mbed TLS]
@@ -122,6 +122,12 @@ ssllib: openssl pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" extraconf: --enable-pkcs11 + - os: ubuntu-24.04 + sslpkg: "libssl-dev" + libname: OpenSSL 3.0.13 + ssllib: openssl + pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" + extraconf: --enable-pkcs11 - os: ubuntu-20.04 sslpkg: "libssl-dev" libname: OpenSSL 1.1.1
@@ -173,7 +179,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] ssllib: [mbedtls, openssl] name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/676?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de
Gerrit-Change-Number: 676
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/676?usp=email )
Change subject: Add Ubuntu 24.04 runner to Github Actions
......................................................................
Add Ubuntu 24.04 runner to Github Actions
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg28942.html
---
M .github/workflows/build.yaml
1 file changed, 8 insertions(+), 2 deletions(-)
.github/workflows/build.yaml +8 -2
@@ -106,7 +106,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04, ubuntu-22.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] sslpkg: [libmbedtls-dev] ssllib: [mbedtls] libname: [mbed TLS]
@@ -122,6 +122,12 @@ ssllib: openssl pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" extraconf: --enable-pkcs11 + - os: ubuntu-24.04 + sslpkg: "libssl-dev" + libname: OpenSSL 3.0.13 + ssllib: openssl + pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" + extraconf: --enable-pkcs11 - os: ubuntu-20.04 sslpkg: "libssl-dev" libname: OpenSSL 1.1.1
@@ -173,7 +179,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] ssllib: [mbedtls, openssl] name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/676?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de
Gerrit-Change-Number: 676
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged